2.1.1U1 Duplicate Key Commands

[Home Fries]

When adding key commands to cycle the data cartridge, LCTL+LALT+C is used to cycle the cartridge selection down. This command also maps to the Sidewinder Uncage by default.

 

{combos = {{key = "C", reformers = {"LAlt","LCtrl"}}}, down = 3314, cockpit_device_id = devices.WEAPON_SYSTEM, value_down = 1.0, name = _("IR-missile uncage"), category = _("Weapons")},
<...>
{combos = {{key = 'C', reformers = {'LCtrl', "LAlt"}}},down = 3010, value_down = -1.0, cockpit_device_id = devices.NAVIGATIONPANEL, name = _('Select Data Cartridge - Down'), category = _('Navigation')},

 

 

 

Also, the duplicate lighting command bug is still present.

[Home Fries]

One more thing: when cycling the data cartridge up, it starts at 0 and stops at 5 (as you would expect). However, cycling down reverts back to 5 after cycling through 0. I recommend being consistent in both directions (preferably stopping at the max rather than cycling as it presently does with up).

[Home Fries]

Just noticed this on the latest versions (1.5.7.9411 and 2.1.1.9429):

 

In the joystick default.lua lines 510-511, you have the same command using different groupings.

 

{down = 3004, cockpit_device_id = devices.LIGHTS, value_down = 1.0, name = 'Taxi/landing lights switch', category = 'Lights panel'},
{down = 3004, cockpit_device_id = devices.LIGHTS, value_down = 1.0, name = _('Taxi/landing lights switch'), category = _('Lights')},

 

Should one of these lines be removed? Also, out of curiosity, what is the difference between naming something in quotes and bounding the quotes with _()?

[Flagrum]

I believe, _( ... ) is a function call which returns the localized/translated text.

[Home Fries]

I believe, _( ... ) is a function call which returns the localized/translated text.

 

Thanks!