Unit attributes too general/incorrect

[WirtsLegs]

So not something that is obvious to most people playing the game, but it seems the attributes given to units (fetchable in lua with getDesc()) are given out way too liberally.

Specifically there is no distinction between a hummer and a proper APC like a LAV-25

The hummer's attributes:

{ 2, 17, 104, "Redacted", "APC", "ATGM", "Datalink", "Infantry carriers", "Armored vehicles", "All", "Ground Units", "Ground Units Non Airdefence", "Armed ground units", "Vehicles", "Ground vehicles", "Armed vehicles", "AntiAir Armed Vehicles", "NonAndLightArmoredUnits", "LightArmoredUnits" }

The Lav

{ 2, 17, 26, "Redacted", "APC", "Infantry carriers", "Armored vehicles", "All", "Ground Units", "Ground Units Non Airdefence", "Armed ground units", "Vehicles", "Ground vehicles", "Armed vehicles", "AntiAir Armed Vehicles", "NonAndLightArmoredUnits", "LightArmoredUnits" }

 

The only difference is the 3rd attribute which is provided as a index, not sure what they are but they vary between different "APC"s such that its not usable as a discriminator, and then in this case ATGM and DATALINK which are obviously not any use for distinguishing these two classes of vehicle

 

This makes any kind of scripting that needs to be able to understand unit type difficult as we have to separately maintain a hard-coded list of vehicles vs their type

 

I would propose removing the APC attribute from anything that isn't actually an APC (some of those light vehicles have some basic armour but they are not classed as APCs), the Infantry Carrier attribute works to tag things that can carry infantry so that discrimination is retained.

[kira_mikamy]

yeah the attribute are manager very wild.
null
never understand what this means

 ["IFV"] = {"Infantry carriers","Armored vehicles","Armed vehicles","AntiAir Armed Vehicles","LightArmoredUnits",},
 ["APC"] = {"Infantry carriers","Armored vehicles","Armed vehicles","AntiAir Armed Vehicles","LightArmoredUnits",},