2.5.6 changes semantics of screen.aspect

[derammo]

In 2.5.5 and before, if you set an aspect ratio in the graphics settings UI, this value is provided in screen.aspect in the MonitorSetup lua scripts.

 

In 2.5.6, screen.aspect is just set based on the size of screen (i.e. width/height) and does not consult the value in the UI.

 

Therefore, monitor setup lua scripts that rely on getting the UI-configured value in this way will start having unexpected aspect ratios, since the meaning of this value was apparently silently changed. I am suggesting this is a bug. It takes me an insane amount of time to test this, so I did not confirm this repeatedly.

[yeldraw1]

aspect

 

Have you figured a way around this? cause Im having the same issue

[derammo]

Have you figured a way around this? cause Im having the same issue

 

We just stopped using the value from the UI and hard coded the aspect ratio in the Lua. Somehow you are figuring out the Width and Height of the main viewport in your Lua, so just divide those two to get the aspect ratio, and don't rely on the UI value.

[Sixpack49DCS]

Same problem 3 monitor in operation together 1920x2616

 

The entry of the screen.aspect in the MonitorSetup.lua has no effect

 

name = _('A-10C');

Description = '24+15+10'

Viewports =

{

Center =

{

x = 0;

y = 0;

width = 1920;

height = 1080;

viewDx = 0;

viewDy = 0;

aspect = 1,7777777777778

The garfik is compressed to the first monitor

Edited February 22, 2020 by Sixpack49DCS

[Yofich]

same for me

[derammo]

Same problem 3 monitor in operation together 1920x2616

 

The entry of the screen.aspect in the MonitorSetup.lua has no effect

 

name = _('A-10C');

Description = '24+15+10'

Viewports =

{

Center =

{

x = 0;

y = 0;

width = 1920;

height = 1080;

viewDx = 0;

viewDy = 0;

aspect = 1,7777777777778

The garfik is compressed to the first monitor

 

You have a comma in your aspect ratio instead of a decimal point. So your aspect ratio ends up being 1.

 

Test in Lua interpreter:

 

Lua 5.1.5  Copyright (C) 1994-2012 Lua.org, PUC-Rio
> a = 1,5
> print (a)
1
> a = 1.5
> print(a)
1.5
>

[Sixpack49DCS]

You have a comma in your aspect ratio instead of a decimal point. So your aspect ratio ends up being 1.

 

Test in Lua interpreter:

 

Lua 5.1.5  Copyright (C) 1994-2012 Lua.org, PUC-Rio
> a = 1,5
> print (a)
1
> a = 1.5
> print(a)
1.5
>

 

 

Thanks for the info

It's sometimes the little things white a punk instead of a comma

It's back, the picture is OK

Super

[derammo]

Dear mods: could you please classify this as a BUG / NOT A BUG / FIXED ?

[imaner76]

I wanted to play this today but I can not get the aspect ratio to change from this widend view. It used to be perfect, I can't play like this any idea? :cry:

 

 

Normally, looks like this, or as three screens, below. :(

 

 

[imaner76]

[derammo]

ok, but that doesn't change the bug I am reporting. screen.aspect is no longer available in the Lua file. Of course it is easy to work around, but it's a bug if devs just randomly remove stuff from an API :)