[MINOR] Long press on NADIR "EFF" button coded wrong

[scoobie]

That's no big deal, but the code is waiting for the user to release the button and only then checks how much time has passed since the button was pressed. If it's >= 2 seconds, a long press action is triggered (e.g. "abandon waypoint data entry"). If less - short press action (e.g. "delete the rightmost digit in the display").
That's not how such things are programmed in real life hardware, never. The code must continually (or at time intervals not less greater than, say 0.1-0.2 s) check the elapsed time and if it's >= 2 s and the button is still depressed, it has to trigger long press action ON ITS OWN, without waiting for the user to release the button. Of course short press is detected on button release, that works OK.

You can test it easily. Select "BUT" ("WPT") on that rotary selector, press any waypoint number you want on the keypad, and press ENT. The top line of the display will start blinking.
Now, press AND HOLD "EFF" ("DEL") button and keep it depressed as long as you like - nothing will happen, you may hold it for half an hour. Now release the button and only now data entry will get cancelled - the top display line will stop blinking.

EDIT:

I've found more problems with NADIR and gathered them (including the one above) in a separate topic here:

 

Edited April 3 by scoobie