Touch Portal App

[Kyle_Katarn]

On 8/5/2024 at 2:11 AM, xoomigo said:

@Kyle_Katarn, I have gone through your files and I get what you are doing. They look okay and should not impact other users.

All, I have regenereated the PP files from the latest DCS-BIOS release and applied the customizations. However, I have yet to perform any basic sample tests - will do so within the next few days.

Ok, no hurry.
I'll start my summer brake on monday so I'll not be near a DCS copy for 3 weeks.

[xoomigo]

On 8/10/2024 at 1:26 AM, virgo47 said:

Hi @xoomigo, there is some progress. I can see more lines with NS430 in the output now - see the attached log. It seems it knows about it now + the initial state is communicated. However, when I rotated a knob (encoder type) on NS430 no events were sent.

Hmm.., DCS-BIOS does not appear to be generating the events.

Can you please test the NS430 events with the tool?

https://github.com/DCS-Skunkworks/BIOSBuddy

[xoomigo]

DCS-COINS Version 5 is now available.

• Revamped to adapt to latest Skunkworks DCS-BIOS (Note: Compatible only with version 0.8.2 going forward)
• Optimized for smaller TP payload
• Repacked with DCS-BIOS 0.8.2 (incl. support for F-4E, Mirage-F1BE, OH-58D and UH-60L)
• Enums for L-39 (by @virgo47) and FA-18C_hornet (add-on by @Kyle_Katarn

https://www.digitalcombatsimulator.com/en/files/3319022/

[xoomigo]

@virgo47, I have also added the function '=ictr'<max value> (inversion of '=ctr'<max value>) that you have asked for. Try it out and let me know how it goes.

[virgo47]

Thanks for the release! I'm testing it, the first thing I encountered during the installation is this:

This happens rather randomly when I reopen Select Modules window and just press Next. When it happens it keeps happening, but the selection itself doesn't seem to be the problem. E.g. I removed NS430 and saved (Next), this error appeared. I reopened the window, NS430 was unselected, I selected it again, and Next worked fine this time. The same happened with other checkboxes, but I haven't tried them systematically.

I was also surprised... I thought the modules I own were preselected previously, but maybe that's just my wrong assumption. I had to click all the modules I had. Is that how it should work?

On a positive note, L-39 patches are in as expected, thanks a lot, the initial switch positions are now better.

Edited September 15, 2024 by virgo47

[virgo47]

4 hours ago, xoomigo said:

@virgo47, I have also added the function '=ictr'<max value> (inversion of '=ctr'<max value>) that you have asked for. Try it out and let me know how it goes.

I've tested it this way.

1. In UH-1H.pp I redefined this line (one of the reversed knobs): VHFFM_VOL|vhffm_vol|VHF FM Volume Control|6|3200|=ictr(65535)|0
2. I created the TPP file with the installer.
3. I check that the same PP modification is inside the TPP file.
4. I imported the plugin.
5. But the slider still sends 0 for lowest slider value and 65535 for maximum slider (checked with dcs-coins -v). This is the same as with =ctr...

What did I do wrong? (I tried to create the slider from scratch as well, no change.)

Edited September 15, 2024 by virgo47

[xoomigo]

7 hours ago, virgo47 said:

This happens rather randomly when I reopen Select Modules window and just press Next. When it happens it keeps happening, but the selection itself doesn't seem to be the problem. E.g. I removed NS430 and saved (Next), this error appeared. I reopened the window, NS430 was unselected, I selected it again, and Next worked fine this time. The same happened with other checkboxes, but I haven't tried them systematically.

@virgo47 This is really strange. I tried the steps a few times that you mentioned but failed to get the error concerned. When you get the error, do not proceed with "Next" and share the generated files in:

• folder Munt.G_DCS-COINS
  • DCS-COINS.cfg, ACJSON.cfg
• folder Munt.G_DCS-COINS\acdb
  • aircraftModules.cfg

Did anyone else get the same problem?

[xoomigo]

7 hours ago, virgo47 said:

I was also surprised... I thought the modules I own were preselected previously, but maybe that's just my wrong assumption. I had to click all the modules I had. Is that how it should work?

On initial DCS-BIOS installation, all modules are unselected. Subsequently, it will "remember" your selection.

6 hours ago, virgo47 said:

I've tested it this way.

1. In UH-1H.pp I redefined this line (one of the reversed knobs): VHFFM_VOL|vhffm_vol|VHF FM Volume Control|6|3200|=ictr(65535)|0
2. I created the TPP file with the installer.
3. I check that the same PP modification is inside the TPP file.
4. I imported the plugin.
5. But the slider still sends 0 for lowest slider value and 65535 for maximum slider (checked with dcs-coins -v). This is the same as with =ctr...

What did I do wrong? (I tried to create the slider from scratch as well, no change.)

 

No, you did no wrong. I had actually rushed this and did not get a chance to test it. Will look into it.

[virgo47]

4 hours ago, xoomigo said:

@virgo47 This is really strange. I tried the steps a few times that you mentioned but failed to get the error concerned. When you get the error, do not proceed with "Next" and share the generated files in...

I started the setup, went to module selection (now remembered, thanks for the explanation with new DCS-BIOS installation), Next, OK. Tried again, and click on the Next generated the error. Files are included - copied with the error still on screen.

ACJSON.cfg DCS-COINS.cfg aircraftModules.cfg

[xoomigo]

2 hours ago, virgo47 said:

I started the setup, went to module selection (now remembered, thanks for the explanation with new DCS-BIOS installation), Next, OK. Tried again, and click on the Next generated the error. Files are included - copied with the error still on screen.

From the files, it look like it got the error while generating the aircraftModules.cfg for or after NS430.

Please share or pm me your DCS.Openbeta/Scripts/DCS-BIOS/BIOS.lua file.

Thanks.

[virgo47]

57 minutes ago, xoomigo said:

From the files, it look like it got the error while generating the aircraftModules.cfg for or after NS430.

Please share or pm me your DCS.Openbeta/Scripts/DCS-BIOS/BIOS.lua file.

Thanks.

I suspected NS430 somehow. File is included, it differs from the original BIOS.lua only in commented-out modules (and LF vs CRLF, but that is inconsequential, I guess).

BIOS.lua

[xoomigo]

2 hours ago, virgo47 said:

I suspected NS430 somehow. File is included, it differs from the original BIOS.lua only in commented-out modules (and LF vs CRLF, but that is inconsequential, I guess).

I tried using all your files here but still could not get the error.

But one thing to note is that your BIOS.lua was not modified by the setup.

Initially, I got a warning from my Norton 360 anti-virus stopping the file changes. I had to set it to trust DCS-COINS_Setup.exe to enable it to run properly. Can you try doing the same with your anti-vrus/anti-malware program and then try running setup again?

Thanks.

[virgo47]

21 minutes ago, xoomigo said:

I tried using all your files here but still could not get the error.

But one thing to note is that your BIOS.lua was not modified by the setup.

Initially, I got a warning from my Norton 360 anti-virus stopping the file changes. I had to set it to trust DCS-COINS_Setup.exe to enable it to run properly. Can you try doing the same with your anti-vrus/anti-malware program and then try running setup again?

Thanks.

I didn't have problems with the antivirus (using MS default one for Windows). I deleted the whole DCS-BIOS folder from my Saved Games\...\Scripts and started the installer again. After installation, the dir is created fresh (15:57 was current local time):

The BIOS.lua file was in its original form. After selecting modules, the installer changed the file, commenting out all unused modules. As long as I selected only F-5, it was OK - I could repeatedly open and "Next" the Select Modules windows. When I selected NS430, it accepted it the first time, but the next cycle (Select Modules, Next) showed the error again.

Next, I reopen the Select Modules again, unselected NS430 and selected my modules - and the error appeared again. But the next cycles (when NS430 was deselected after entering the page) were fine again. It seems it doesn't like when NS430 is ticked when I open that Select Modules page.

I also noticed a brief moment that the changed checkbox shortly shows its original state after I press Next, not even NS430 but Yak-52 as well. Not sure what that is (some model/UI sync?).

Now, obviously, this is no showstopper as the module does not work properly anyway (on DCS-BIOS side, if I understand it correctly).

BTW: What makes you say that my BIOS.lua was not modified by the setup? I see the lines edited every time I confirm the Select Modules window.

Edited September 16, 2024 by virgo47

[xoomigo]

14 hours ago, virgo47 said:

The BIOS.lua file was in its original form. After selecting modules, the installer changed the file, commenting out all unused modules. As long as I selected only F-5, it was OK - I could repeatedly open and "Next" the Select Modules windows. When I selected NS430, it accepted it the first time, but the next cycle (Select Modules, Next) showed the error again.

Next, I reopen the Select Modules again, unselected NS430 and selected my modules - and the error appeared again. But the next cycles (when NS430 was deselected after entering the page) were fine again. It seems it doesn't like when NS430 is ticked when I open that Select Modules page.

Ah, finally. I could replicate the error, following your steps here. Never felt so relieved about discovering my programming bug.

I have uploaded a fix to the official download site. But no need for you to download and redo everything from there. Just overwrite the DCS-COINS_Setup.exe from the attached copy here.

DCS-COINS_Setup.zip

14 hours ago, virgo47 said:

BTW: What makes you say that my BIOS.lua was not modified by the setup? I see the lines edited every time I confirm the Select Modules window.

Because the file was in its original form - no "require" statement was remarked off. And the file was still in in Unix text file format (only LF for each line). If it was modified, it would be in Windows (CR LF) text file - where the pair of CR/LF will terminate each line in the file.

[virgo47]

2 hours ago, xoomigo said:

Because the file was in its original form - no "require" statement was remarked off. And the file was still in in Unix text file format (only LF for each line). If it was modified, it would be in Windows (CR LF) text file - where the pair of CR/LF will terminate each line in the file.

Ops... silly me, I copied the one from the zip having both zip and dir next to each other!

I tested this fix and the error is gone, thanks. I'm looking forward to that ictr= fix as that will make the volume sliders in UH-1H work as expected (some of them at least, e.g. that VHFFM_VOL is affected).

[xoomigo]

2 hours ago, virgo47 said:

I tested this fix and the error is gone, thanks.

Great! Thanks for the prompt confirmation.

2 hours ago, virgo47 said:

 I'm looking forward to that ictr= fix as that will make the volume sliders in UH-1H work as expected (some of them at least, e.g. that VHFFM_VOL is affected).

Okay, done! I had also updated the UH-1H.pp file. Attached is a zipped combo of the patched DCS-COINS.exe and UH-1H.pp file (VHFFM_Vol and INT_VOL) to update your copy.

patch_2024-09-17.zip

Edited September 17, 2024 by xoomigo

[virgo47]

3 hours ago, xoomigo said:

Okay, done! I had also updated the UH-1H.pp file. Attached is a zipped combo of the patched DCS-COINS.exe and UH-1H.pp file (VHFFM_Vol and INT_VOL) to update your copy.

Hi Xoomigo, I've tried the patch, I see the new patched EXE in my TPP, it all looks OK:

I reimported it into Touch Portal, but when I try it, it doesn't work. With verbose output, I still see 65535 with slider maxed up, not 0.

I've had my UH-1H.pp already modified, I identified these changes (two of those are the same as you provided):

ADF_GAIN|adf_gain|ADF Gain|6|3200|=ictr(65535)|0
INT_VOL|int_vol|Intercom Volume|6|3200|=ictr(65535)|0
UHF_VOL|uhf_vol|UHF Volume Control|6|3200|=ictr(65535)|0
VHFFM_VOL|vhffm_vol|VHF FM Volume Control|6|3200|=ictr(65535)|0
VHFNAV_VOL|vhfnav_vol|VHF NAV Volume Control (step size less than 8192 may not work)|6|8192|=ictr(65535)|0

Is there something else I can try to see what is wrong?

Edited September 17, 2024 by virgo47

[xoomigo]

@virgo47,

Note that verbose output shows DCS-BIOS values as-is. It's the values which the plugin sends to both TP and DCS-BIOS that are changed.

I had tested by turning the knob on the cockpit panel.

• By default, it is turned all the way to the right - which should be 0 in DCS-BIOS, translated to 100 by the plugin to TP. (Just realized I had missed to adjust this default in the PP file)
• If turned anti-clockwise all the way, DCS-BIOS shows increase in value until to hits 65535, with plugin value to TP decreasing until it is 0.
• If turned clockwise, DCS-BIOS show decrease in the values until it hits 0, with plugin value to TP increasing until it is 100.

Previously, the plugin values were generated in the opposite directional increase/decrease.

Frankly, I have yet to progress to the level of operating the radio/comms and hence, are not familiar with how the controls should actually work. Hence, I am open to being enlightened if my assumptions are incorrect.

Edited September 18, 2024 by xoomigo

[virgo47]

On 9/18/2024 at 2:02 AM, xoomigo said:

@virgo47,

Note that verbose output shows DCS-BIOS values as-is. It's the values which the plugin sends to both TP and DCS-BIOS that are changed.

I had tested by turning the knob on the cockpit panel.

• By default, it is turned all the way to the right - which should be 0 in DCS-BIOS, translated to 100 by the plugin to TP. (Just realized I had missed to adjust this default in the PP file)
• If turned anti-clockwise all the way, DCS-BIOS shows increase in value until to hits 65535, with plugin value to TP decreasing until it is 0.
• If turned clockwise, DCS-BIOS show decrease in the values until it hits 0, with plugin value to TP increasing until it is 100.

Previously, the plugin values were generated in the opposite directional increase/decrease.

Frankly, I have yet to progress to the level of operating the radio/comms and hence, are not familiar with how the controls should actually work. Hence, I am open to being enlightened if my assumptions are incorrect.

Hi, I PM'd you with the demonstration video.

[xoomigo]

@virgo47 and all,

Good news!

DCS-COINS =ictr() function had been fixed and the UH-1H PP files have been updated with volume controls to use it.

You can get the updated files from the usual link.

https://www.digitalcombatsimulator.com/en/files/3319022/

[virgo47]

6 hours ago, xoomigo said:

@virgo47 and all,

Good news!

DCS-COINS =ictr() function had been fixed and the UH-1H PP files have been updated with volume controls to use it.

You can get the updated files from the usual link.

https://www.digitalcombatsimulator.com/en/files/3319022/

@xoomigo Thank you - I can confirm the reverse sliders now work! However, I have bad news as well - any switch now sends NaN instead of normal values. If I import plugin from 09-15, it sends numbers:

Command Sent: mgdc_l-39_ac_front_master_arm [MGDC_L-39_AC_FRONT_MASTER_ARM 1]
Command Sent: mgdc_l-39_ac_front_master_arm [MGDC_L-39_AC_FRONT_MASTER_ARM 0]

Current plugin sends this (different switch, but all do the same):

Command Sent: mgdc_l-39_ac_front_asp_fkp [MGDC_L-39_AC_FRONT_ASP_FKP NaN]
Command Sent: mgdc_l-39_ac_front_master_arm [MGDC_L-39_AC_FRONT_MASTER_ARM NaN]

This crashes DCS instantly.

So somehow we need the best from both versions. I'd recommend pulling the last version out of the upload page for the reputation sake. Finally, as a minor thing, I found that VHF volume is also inverted, I don't know how I missed it (maybe my head was inverted), so the set of changes for UH-1H is:

ADF_GAIN|adf_gain|ADF Gain|6|3200|=ictr(65535)|100
INT_VOL|int_vol|Intercom Volume|6|3200|=ictr(65535)|100
UHF_VOL|uhf_vol|UHF Volume Control|6|3200|=ictr(65535)|100
VHFCOMM_VOL|vhfcomm_vol|VHF Volume Control (step size less than 8192 may not work)|6|8192|=ictr(65535)|100
VHFFM_VOL|vhffm_vol|VHF FM Volume Control|6|3200|=ictr(65535)|100
VHFNAV_VOL|vhfnav_vol|VHF NAV Volume Control (step size less than 8192 may not work)|6|8192|=ictr(65535)|100

Sorry if you felt under pressure, no need to rush, the capability is awesome and I'll wait for it. Or you can send me the stuff privately and I'll test it before release, if you want.

[xoomigo]

35 minutes ago, virgo47 said:

@xoomigo Thank you - I can confirm the reverse sliders now work! However, I have bad news as well - any switch now sends NaN instead of normal values. If I import plugin from 09-15, it sends numbers:

Command Sent: mgdc_l-39_ac_front_master_arm [MGDC_L-39_AC_FRONT_MASTER_ARM 1]
Command Sent: mgdc_l-39_ac_front_master_arm [MGDC_L-39_AC_FRONT_MASTER_ARM 0]

Current plugin sends this (different switch, but all do the same):

Command Sent: mgdc_l-39_ac_front_asp_fkp [MGDC_L-39_AC_FRONT_ASP_FKP NaN]
Command Sent: mgdc_l-39_ac_front_master_arm [MGDC_L-39_AC_FRONT_MASTER_ARM NaN]

This crashes DCS instantly.

Aaargh! This is bad.

Okay, I have rolled back the download to the previous version. Thanks for the quick testing and heads-up.

[xoomigo]

1 hour ago, virgo47 said:

 Or you can send me the stuff privately and I'll test it before release, if you want.

It was due to a careless mistake.

Anyway, here's the patched version of the DCS-COINS.exe for you to help confirm the testing.  I have tested and it no longers send NaN.

DCS-COINS.zip

[virgo47]

1 hour ago, xoomigo said:

It was due to a careless mistake.

Anyway, here's the patched version of the DCS-COINS.exe for you to help confirm the testing.  I have tested and it no longers send NaN.

DCS-COINS.zip 23.25 MB · 0 downloads

Just a quick update - the patch fixed the problem!

And I messed with that VHF volume after all, probably mistaking VHF NAV with VHF (non-NAV), I'll post final set when I go through all ctr controls. For now, thank you VERY MUCH for the fix - and for inverted sliders!

[xoomigo]

@virgo47, thanks for testing the patch and confirming that issue is rectified.

I have uploaded the patch to the official download page - included changes to the UH-1H VHFCOMM_VOL and VHFNAV_VOL controls to use the inverted and normal functions respectively.

Will await your final set of controls for the inverted function.