[WORKING AS INTENDED]Canopy Open Bind not working properly

[Captain Orso]

This is a very minor bug.

 

 [bug] Assign Canopy Open to an On/Off switch. Assert switch and the canopy starts opening. Release switch and the canopy continues to open. Reassert switch and the canopy stops opening. Assert switch again and the canopy starts opening again, etc. etc.

 

[WAD] Assign Canopy Close to an On/Off switch. Assert switch and the canopy starts closing. Release switch and the canopy stops opening.

[BIGNEWY]

Hi, 

 

This is working as intended, the open close is a open or close key bind, a simplified action. 

 

We also have three separate key binds for open / hold / close, tapping the hold key will interrupt the canopy action

 

thanks

[Captain Orso]

3 hours ago, BIGNEWY said:

Hi, 

 

This is working as intended, the open close is a open or close key bind, a simplified action. 

 

We also have three separate key binds for open / hold / close, tapping the hold key will interrupt the canopy action

 

thanks

 

These are the pertinent lines in the 'default.lua' file:

 

{    down = cpt_commands.CanopySwitchOpen,        up =  cpt_commands.CanopySwitchOpen,        cockpit_device_id = devices.CPT_MECHANICS,        value_down =  1.0,    value_up = 0.0,        name = _('Canopy Control Switch - OPEN'),    category = {_('Right Wall'), _('Systems')}},
{    down = cpt_commands.CanopySwitchClose,                                                    cockpit_device_id = devices.CPT_MECHANICS,        value_down =  0.0,                        name = _('Canopy Control Switch - HOLD'),    category = {_('Right Wall'), _('Systems')}},
{    down = cpt_commands.CanopySwitchClose,        up =  cpt_commands.CanopySwitchClose,        cockpit_device_id = devices.CPT_MECHANICS,        value_down = -1.0,    value_up = 0.0,        name = _('Canopy Control Switch - CLOSE'),    category = {_('Right Wall'), _('Systems')}}, 

 

The 'CLOSE' line uses 'value_up = 0.0' on 'cpt_commands.CanopySwitchClose' so that when you press and then release the 'CLOSE' button, the canopy stops closing on releasing the button press, which is exactly what can be observed.

 

The 'OPEN' line also uses 'value_up = 0.0', but on 'cpt_commands.CanopySwitchOpen'. When you release pressing the 'OPEN' button the canopy begins to open, but when release the 'OPEN' button the canopy continues to open until you press 'OPEN' again, or 'HOLD'.

 

Obviously since 'OPEN' and 'CLOSE' are written using the exact same format, they are intended to work exactly the same; but the do not. The 'value_up = 0.0' parameter of the 'OPEN' line is NOT working as intended, it is doing nothing and could as well not be there.

 

It's a very minor bug, but there it is.

[cofcorpse]

There is no errors. I'm sorry, but your assumption is incorrect. The OPEN position is solenoid held, while the CLOSE position is spring loaded to the HOLD position. Thus, although these commands have the same format, they work in different ways.

[Captain Orso]

Thanks for the reply.

 

Clicking the switch in-cockpit confirm your statement.

 

Odd the way 'default.lua' is written, but what the heck.

[cofcorpse]

I'll try to explain.

Imagine you using your finger to press this switch - it's the down command, 1. Then you remove your finger from the switch - it's the up command, 0. What happens with the switch is also affected by the switch itself. It can return back, if it is springloaded, or it can remain in the switched position, if it is solenoid held.

Hope this helps a little!

[Captain Orso]

LOL thanks for the extended explanation. You are above and beyond 

 

I'm only saying that the coding of 'default.lua' is... easy to misinterpret.