fixed Cannot close the mission with "END MISSION" button in Campaigns and incorrect Logbook update.

LordOrion · January 29, 2023

Seen on Open Beta v2.8.2.35759
Was working ok with OB v2.8.1.34667.2.
Not sure (don't remeber) about OB v2.8.2.35632.

Problem description:

When I enter the CAMPAIGN page, the status of all campaigns is set to "INACTIVE", including for capaigns I've completed and the ones I'currently played (see attached "Campaign-Bug.jpg" picture).

Procedure to reproduce: Just enter the CAMPAIGN page, any module Tab will do (it is not restricet to "My Campaign" tab).

(WORKAROUND) : Click on one of the other module campaign's tab and then come back to the previous one then the campaign status appears to be correct (see attached "Campaign-Ok.jpg" picture).

Exit and Enter the Campaign page to see the problem again.

I've included my Logbook file (should it be useful).

logbook.lua

Edited January 29, 2023 by LordOrion

LordOrion · January 29, 2023

Seen on Open Beta v2.8.2.35759
Was working ok with OB v2.8.1.34667.2.
Not sure (don't remeber) about OB v2.8.2.35632.

Problems description:

1) At the end of a campaign mission, clicking the "END MISSION" does not close the AAR page as it sould and you need to click the "CLOSE" button instead.

2) Moreover, clicking the "END MISSION" button actually updates the logbook for each click, i.e.:

Supposing we flown for 1h and hit 4 targets, clicking the "END MISSION" button 3 times, the logbook be updated adding 3h of flight and 12 more targets hits!

3) Last: Probably being forced to click the "CLOSE" button to exit, the Campaing status is updated but does not advance to the next mission, i.e.: the last played mission is marked as completed but the next one is not available for playing.

@Devs: this is actually blocking the campaing progress, so I hope you can fix it ASAP (pliz!).

Edited January 29, 2023 by LordOrion

Flappie · January 29, 2023

Hi. See here:

The issue is now reported and a fix is in the works.

Gryzor · January 29, 2023

Its not working either in v2.8.2.35632.

Was working ok with OB v2.8.1.34667.2.

1 minute ago, Flappie said:

Hi. See here:

The issue is now reported and a fix is in the works.

me_logbook.lui "fix" by user it doesnt work in 2.8.2

BuzzLine · January 29, 2023

@Flappie : this may be another issue than my "favorite" bug. There might be something fishy in the parsing of campaigns, I have this brand new error in my DCS log :

2023-01-29 23:14:33.503 DEBUG   LuaGUI (Main): GUI Error: [string "./MissionEditor/modules/me_campaign.lua"]:854: attempt to index local 'campaign' (a nil value)
GUI debug.traceback: stack traceback:
	[C]: ?
	[string "./MissionEditor/modules/me_campaign.lua"]:854: in function 'chooseNextMission'
	[string "./MissionEditor/modules/me_campaign.lua"]:1040: in function 'onReceiveMissionResults'
	[string "./MissionEditor/modules/me_debriefing.lua"]:391: in function 'endMission'
	[string "./MissionEditor/modules/me_debriefing.lua"]:351: in function 'onChange'
	[string "./dxgui/bind/Button.lua"]:22: in function 'callback'
	[string "./dxgui/bind/Widget.lua"]:368: in function <[string "./dxgui/bind/Widget.lua"]:363>

I have the same symptoms as here :

Investigating ...

Flappie · January 29, 2023

Thanks @BuzzLine, I'll wait for your fedback.

I've just tried the campaigns page issue in current OB: I cannot reproduce the issue. The "Active" word appears right away for my active campaigns.

BuzzLine · January 30, 2023

For me the issue is only on user campaigns, not paid campaigns. I saw both symptoms: the EndMission button not working as well as the Campaign page resetting all user campaigns to 'inactive'.

I dug in the code and I found an extra slash in the path DCS generates when listing campaigns. Because of that, that path does not exactly match the one listed in logbook.lua. I could provide a (very ugly) fix, but then I'm not sure how to explain the miraculous recovery of all the campaign statuses that is mentioned in the other thread ("Incorrect status in Campaigns Page"). So I'm not confident in that fix for now, I need to dig some more.
I have to sleep a bit for now but I'll take another look tomorrow night if ED has not fixed it already.

If anyone wants to pickup the trail: look at function "findCampaigns(dirName, a_modulId, a_developerName)" in me_campaigns.lua, if dirName ends with '/' already, there will be double slashes in the paths inserted in campaignsByPath. Those will/may not match the path "game.campaign" in "function onReceiveMissionResults()" that (for me at least) has no extra slash. That will cause nil unhappiness in various places.

e.g.:
C:/Users/BuzzLine/Saved Games/DCS/Missions/Campaigns/en//_debug_campaign_parse/debug_campaign_parse.cmp <= generated by findCampaigns
C:/Users/BuzzLine/Saved Games/DCS/Missions/Campaigns/en/_debug_campaign_parse/debug_campaign_parse.cmp <= read from logbook.lua

Does anyone knows if Lua has standard path.normalize or at least path.join ? It'd be nicer than doing it by hand.

Cheers,
Buzz

BuzzLine · January 30, 2023

OK, answering to myself: the magic switch works because it does not call the same function and the directories are a bit different :

***** BuzzLog: in refreshCampaigns, calling loadDir with campaignDir 	C:/Users/Windows/Saved Games/DCS/Missions/Campaigns/en/
vs
***** BuzzLog: in onListModulsChange, calling loadDir with item.dir	C:/Users/Windows/Saved Games/DCS/Missions/Campaigns/en

No idea why the paths are not the same but this explains why the campaigns magically reappear. However on mission end, it is similar to the first call so the EndMission button will not work (lol, my curse ).

@Flappie : This is my fix in me_campaigns.lua, around line 338. It's not pretty, I'm not proud of it, I would really prefer to fix the root cause, but it gets the job done.

			local fullName
			-- BuzzLine's protection against trailing '/' that causes mismatch between campaignsByPath and game.campaign read from logbook 
			-- note : it's a poor man's os.path.join(dirName,f) but I don't know if we have better
			if string.sub(dirName,-1)=='/' then 
				fullName = dirName .. f 
			else
				fullName = dirName .. '/' .. f 
			end

So, I'm attaching my modded version below. Drop in the main DCS directory DCSWorld\MissionEditor\modules , overwrite existing file.
I have no idea why the issue popped up, why this trailing slash appeared, why now, etc. Also, I don't work for ED so use at your own risks, etc. I just hope this helps people enjoy DCS and their campaigns until a proper fix is found and pushed.

Cheers,
Buzz

me_campaign.lua

bertog · January 30, 2023

Happen the same to me. User campaigns are not updated. I need to click on one of the plane then came back to User Campaign to see the right stuff. Plus yesterday I've hit the "End Mission" issue and now the "Bold Cheetah" campaign is broken. Last mission is "Success" but I cannot go ahead:

null

Flappie · January 30, 2023

@bertog Browse to "Saved Games/DCS.../MissionEditor" and attach your "logbook.lua" file. I'm sure it can be quickly fixed.

I'll soon report this issue.

AdrianL · January 30, 2023

2 minutes ago, Flappie said:

I'll soon report this issue.

Think it is related to this issue

Edited January 30, 2023 by AdrianL

Flappie · January 30, 2023

Yes, it is.

Flappie · January 30, 2023

Issue reproduced and reported. Thanks again, @BuzzLine.

BuzzLine · January 30, 2023

5 minutes ago, Flappie said:

Issue reproduced and reported. Thanks again, @BuzzLine.

Anytime. Happy to help.

bertog · January 30, 2023

1 hour ago, Flappie said:

@bertog Browse to "Saved Games/DCS.../MissionEditor" and attach your "logbook.lua" file. I'm sure it can be quickly fixed.

I'll soon report this issue.

Here the file Thanks

logbook.lua

Edited January 30, 2023 by bertog

Flappie · January 30, 2023

Replace yours with this one. This should do the trick.

logbook.lua

BIGNEWY · January 31, 2023

threads merged

bertog · January 31, 2023

11 hours ago, Flappie said:

Replace yours with this one. This should do the trick.

logbook.lua 17.71 kB · 5 downloads

Thanks now I can move on the campaign. The problem around the incorrect status of the campaign persist.

Thanks again :)

Gryzor · January 31, 2023

So no hot FIX patch is expected in one month??? Cmon ED this is a gamebreaking bug (I know, beta).

BuzzLine · January 31, 2023

9 minutes ago, Gryzor said:

So no hot FIX patch is expected in one month?

I'm guessing the schedule Bignewy gave is for "regular" patches, it does not necessarily mean "no hotfix". Note that it could also mean something big is on the horizon !!! (or the team is taking some holidays, or doing double dose of QA, or going on strike ... )

In the meantime, feel free to grab my me_campaigns.lua from just a few posts above, it should work around the issue (or not, caveat emptor) until a proper fix is provided. Or roll back to stable (you said it, beta !).

Cheers

Gryzor · January 31, 2023

3 minutes ago, BuzzLine said:

I'm guessing the schedule Bignewy gave is for "regular" patches, it does not necessarily mean "no hotfix". Note that it could also mean something big is on the horizon !!! (or the team is taking some holidays, or doing double dose of QA, or going on strike ... )

In the meantime, feel free to grab my me_campaigns.lua from just a few posts above, it should work around the issue (or not, caveat emptor) until a proper fix is provided. Or roll back to stable (you said it, beta !).

Cheers

Many Thanks I would test it tonigh, but I´m afraid about break my logbook.lua for future updates (I have many user campaigns started... a lot of them). I will backup of course...

BuzzLine · January 31, 2023

5 minutes ago, Gryzor said:

I´m afraid about break my logbook.lua for future updates

Definitely make a backup ! I was horrified when I saw all my campaigns disappear I thought my 1200h of flight time had all disappeared... But no, all was there.

My fix, if you decide to try it, should not have any impact on your logbook. Regardless, backup backup backup.

bertog · February 1, 2023

@BuzzLine i've used your fix and I'm able to view my campaigns. I'm again stuck after passed a mission with a broken logbook. Could you explain me how to fix it?

Thanks. Guido

BuzzLine · February 1, 2023

@bertog is your logbook corrupted ? What are the symptoms ? Send your logbook.lua and dcs.log and I'll take a look at it.

bertog · February 2, 2023

The symptoms are sadly the same as previous post. I've successfully completed a mission in the Bold Chetaah campaign and now the campaign don't allow me to go ahead with the next mission. Last time you have kindly fixed my logbook.lua file. If you want to tell how to fix maybe I don't bother you everytime till the fix release

Anyway here the files.

Guido

dcs.log logbook.lua

Sign In

fixed Cannot close the mission with "END MISSION" button in Campaigns and incorrect Logbook update.

Recommended Posts

LordOrion

LordOrion

Flappie

Gryzor

BuzzLine

Flappie

BuzzLine

BuzzLine

bertog

Flappie

AdrianL

Flappie

Flappie

BuzzLine

bertog

Flappie

BIGNEWY

bertog

Gryzor

BuzzLine

Gryzor

BuzzLine

bertog

BuzzLine

bertog

Recently Browsing 0 members