fixed "End Mission" Button

[speed-of-heat]

When I bring up the "score" menu, the "end mission" button, does not seem to have any effect, I press the button it depresses, but i'm left in the score window the mission does not end... the only way I have to exit a mission seems to be to quit from the "esc" menu? is that correct/expected behaviour?

[TynMahn]

I too have encountered this problem, and recently.

 

I have, on at least 3 occasions, ran into long standing mostly minor but, mostly really frustrating issues, like this, that have been around in this sim for months, even years before they are addressed, if ever.

 

The other two issues that I can think of off of the top of my head right now persisted for YEARS before they were finally resolved. Not only did they persist for years, they were never even really acknowledged by the developer. Nothing was said, by the developer, about them knowing about and looking into the problem and no help or temporary solution was offered to alleviate the enjoyment killing experience caused by the issue.

 

It seems, from the fact that this post has languished with no reply since November 2018, (a full year prior to my encountering the same issue) that this is yet another example.

[rob10]

I too have encountered this problem, and recently.

 

I have, on at least 3 occasions, ran into long standing mostly minor but, mostly really frustrating issues, like this, that have been around in this sim for months, even years before they are addressed, if ever.

 

 

....

 

 

It seems, from the fact that this post has languished with no reply since November 2018, (a full year prior to my encountering the same issue) that this is yet another example.

 

 

In the case of this issue, while I can understand how it it would be frustrating for you, the fact that it has had no replies until now also suggests it is a random and not very common issue which might explain why it hasn't had much attention from ED. Yes, we'd all like zero bugs (big or small), but reality is that something like this may only affect a small number of users with a very specific hardware combination or combination of other software on their computer or who knows why. If a bunch of other people respond that they've had the issue (and it seems like something that people would report), maybe it'll get looked at.

[Chunks]

When I bring up the "score" menu, the "end mission" button, does not seem to have any effect, I press the button it depresses, but i'm left in the score window the mission does not end... the only way I have to exit a mission seems to be to quit from the "esc" menu? is that correct/expected behaviour?

 

Sorry to bring up a old thread but did you get a fix for this? Just flown a mission for 2 hours and I am unable to end the mission :helpsmilie:

[Drac]

Sorry to bring up a old thread but did you get a fix for this? Just flown a mission for 2 hours and I am unable to end the mission :helpsmilie:

 

Hit the ESC key...expected behavior.

[Chunks]

Won’t mission progress be lost though?

[draconus]

Won’t mission progress be lost though?

No. ESC > Quit. You get debriefing then.

[discwalker]

AFAIK in campaign play mode you must end mission with "end mission" button, only here functioning

[draconus]

AFAIK in campaign play mode you must end mission with "end mission" button, only here functioning

 

Correct but I never did this from ingame score screen. Always esc, quit and "end mission" from debriefing screen.

[drhay53]

Just had this happen on the debrief screen after hitting quit from ESC menu. The score screen was all funky, like it didn't know what the mission file was, or who the player was. The "End Mission" button did nothing, it depressed but performed no action. The only thing I was allowed to do was an action that lost the progress of having flown the mission.

 

I saved Track and Debrief if that is useful to anyone.

[Flappie]

Hi drhay53, I've never seen something like this yet. Can you please attach the dcs.log file showing this issue?

[drhay53]

Hi drhay53, I've never seen something like this yet. Can you please attach the dcs.log file showing this issue?

 

Unfortunately it looks like the dcs.log file has been overwritten at this point.

[Parameter]

Had this problem, and repairing DCS didn't help.

In the attached file, on line 440 there is a GUI error related to logbook, so I tried deleting my logbook at ...\Saved Games\DCS\MissionEditor. This seems to have solved the problem for me: With a new logbook the button works. It is possible that at some point I have somehow broken my logbook.lua with erroneous editing.

 

Now I hope that the problem doesn't somehow resurface. :)

dcs_buttonerror.log

[Flappie]

@ParameterMany thanks for your detailed report, mate.

 

If any of you bump on this bug in the future, please attach your logbook.lua file here ( C:\Users\Flav\Saved Games\DCS\MissionEditor\logbook.lua ).

[BuzzLine]

Issue happened to me, here's some logs and stuff, happy debugging  . 

 

Mission : mission 8 in campaign "caucasus" from module Mirage 2000 (the BD campaign coming with the module). It's the ELINT/CSAR mission.

DCS Version : OpenBeta 2.7.0.4625

 

Issue : On the debriefing screen after the mission, clicking on "End Mission" does not work. Visually the button animation works but the debriefing dialog does not close and the campaign does not progress. 

Expected result : close the debriefing dialog, update logbook, and advance the campaign.

(Note: I didn't check if my logbook.lua was modified or not, or even if it was corrupted...)

 

Attached : 

- dcs.log      with a nice callstack pinpointing a null ref in the debrief parsing logic to update the pilot's logbook

- debriefing.log     for the current mission (probably featuring an unexpected nil somewhere causing the parsing code in 'updateUserStatistics' to fail, I would guess event 1158)

- logbook.lua for      the current pilot (after the failed call)

 

 

PS: I have no way of knowing for sure but I would guess that moving the "if unitTarget" in me_logbook.lua:1122  *before* unitTarget is used (on lines 1118 and 1120) could solve the issue.

 

HTH,

Buzz

debrief_BUG_ENDMISSION.log dcs.log logbook.lua

[BuzzLine]

Fun fact : killing friendly ships increases your score without it being marked as friendly fire, that's just below. The code checks for FF on every type of target except ships... 

 

me_logbook.lua :

if isInsideCoalition(coal, country_idTarget) then --попали по своим
if (victimType == "helicopter") or (victimType == "plane") then 
   faa = faa + 1
elseif victimType == "vehicle" or victimType == "static" then
   fag = fag + 1
end
(...)

 

(and some dev might also have a look at the lostLA update logic a few lines below, it looks suspicious)

Edited April 16, 2021 by BuzzLine

[Ansirial]

Il 16/4/2021 at 01:15, BuzzLine ha scritto:

Issue happened to me, here's some logs and stuff, happy debugging  . 

 

Mission : mission 8 in campaign "caucasus" from module Mirage 2000 (the BD campaign coming with the module). It's the ELINT/CSAR mission.

DCS Version : OpenBeta 2.7.0.4625

 

Issue : On the debriefing screen after the mission, clicking on "End Mission" does not work. Visually the button animation works but the debriefing dialog does not close and the campaign does not progress. 

Expected result : close the debriefing dialog, update logbook, and advance the campaign.

(Note: I didn't check if my logbook.lua was modified or not, or even if it was corrupted...)

 

Attached : 

- dcs.log      with a nice callstack pinpointing a null ref in the debrief parsing logic to update the pilot's logbook

- debriefing.log     for the current mission (probably featuring an unexpected nil somewhere causing the parsing code in 'updateUserStatistics' to fail, I would guess event 1158)

- logbook.lua for      the current pilot (after the failed call)

 

 

PS: I have no way of knowing for sure but I would guess that moving the "if unitTarget" in me_logbook.lua:1122  *before* unitTarget is used (on lines 1118 and 1120) could solve the issue.

 

HTH,

Buzz

debrief_BUG_ENDMISSION.log 208 kB · 4 download dcs.log 83 kB · 3 download logbook.lua 190 kB · 4 download

 

Same thing here after a 2 hour successful mission in a campaign... now I have to refly again. It happens regularly?

[Flappie]

Well, I've never had this issue, and I'd like to find what's broken.

@Parameter pointed out an error in the log about the logbook.lua file, which holds records of one's campaigns progress. I haven't looked at BuzzLine's logbook yet, but I might use more than one anyway.

 

This means I have 2 good reasons to ask for your logbook.lua:

• Find whatever may be wrong in it to find the source of this bug,
• Update your campaign data so it shows your mission succeeded. If you're up to it, I simply need to know which campaign you're flying.

Edited April 17, 2021 by Flappie

[BuzzLine]

29 minutes ago, Flappie said:

Well, I've never had this issue, and I'd like to find what's broken.

 

What's broken is the code in "me_logbook.lua" that is fragile and fails when targetMissionID is empty. Now why targetMissionID is empty and whether it should is another question.

But anyways, moving the "if unitTarget" test a few lines above should do the trick, see around line 1118.  

 

 

 

[Flappie]

You must be right. I've just compared 2.5 and 2.7 me_logbook.lua files, and there were a lot of edits. I'm not that good in Lua to debug this, I'll leave this to ED devs.

[DwarfCZ]

I have exact same issue in F18s Rising Squall campaign mission 2

[BuzzLine]

For the bravest, the impatient, and those who don't mind tinkering with their install, below is a possible fix. Or at least a workaround. I don't know, I'm not an ED dev.  

 

Open file DCSWorld/MissionEditor/modules/me_logbook.lua in your favorite code editor. Look around line 1120 and move the "if unitTarget then" line up four lines.

Here is the code with a bit of context :

-- только убийства игроком
if (event.type == 'kill' and event.initiatorMissionID ~= nil and playerTable.playerUnitId == event.initiatorMissionID) then				
	if event.initiatorMissionID ~= event.targetMissionID then  
		local unitTarget  = MissionModule.unit_by_id[event.targetMissionID]
		if unitTarget then             -- <<<<<<<<<< Buzz: I moved this up here ...
			local coal = playerTable.coalition
			local country_idTarget = unitTarget.boss.boss.id
			local victim = unitTarget
			local victimType = victim.boss.type
		-- if unitTarget then          -- >>>>>>>>>>> Buzz: ... from here 
			if isInsideCoalition(coal, country_idTarget) then --попали по своим
				if (victimType == "helicopter") or (victimType == "plane") then 
					faa = faa + 1
				elseif victimType == "vehicle" or victimType == "static" then 
					fag = fag + 1
				end

 

Note : make a backup before you edit, or just repair your install to revert the change. 

Note 2 : if you don't have a favorite code editor or are confused about all this, then I suggest you wait for an official ED fix. 

 

 

HTH, **caveat emptor**,

Buzz

 

 

[sthompson]

Just experienced this for the first time after completing a mission in Black Sea Resolve (F-5E DLC campaign). This was the first time I flew a campaign mission after upgrading to OB 2.7.

 

 

[lemoen]

I think I fixed mine by renaming Saved Games folder, I put my input folder back in as well as the logbook.lua file found in MissionEditor.

[Flappie]

@lemoenOh, it would mean lobgooks are fine, then. Good news! Thanks for your feedback.